kokrui / pe

0 stars 0 forks source link

Find command should let you specify word or translation #2

Open kokrui opened 10 months ago

kokrui commented 10 months ago

The find command only supports searching for the given keywords in both word and translation fields of a given flashcard.

However, given the target user of a language learner, it is not clear to me what the usecase of searching for keywords of BOTH word and translation fields are.

As a language learner, I would far more likely to want to search either for words or (exclusive or) for translations at any given time. A result of searching for both at once is that if I want to practice words for example containing a certain prefix like "dis", I could get "spoiled" on some translations which contain the substring "dis"

An easy fix would be to split up the find command into two or add a parameter flag to let users specify if they're only searching for words xor translations.

nus-pe-bot commented 10 months ago

Team's Response

Our software is dedicated to allowing users to learn words in multiple languages at the same time. This is one of our major features. As you said when I search for the "dis" prefix the word may appear in multiple languages and may also appear in translations. Since the word is included in our program by the user, it means that the word also needs to be remembered by the user. So I think he should be shown. If these words have similar meanings, users can memorize them at the same time. If the meanings of these words are quite different, it can also help users distinguish.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thanks for your response -- however, I think that this feature is essential to the application.

For clarity, this bug report is about the fact that one should be able to, using a given input substring keyword, search for strings ONLY in "words" XOR ONLY in "translations" of flashcards.

Think about the intended use case of the find command. It's for when a users sits down and wants to begin some language-learning self-practice, but restricting themselves to specific substrings in phrases. Examples of this could be words with a certain prefix (e.g. "un", "dis", etc. if I want to learn "negative" forms of words), words in a specific grammatical conjugation (e.g. "ing" if I want to learn words in continuous tense").

In such a case, where I want to find all english words with "ing" so I can test myself on the German translations of these words in continuous tense, why would I possibly want a word like "twin" to show up in my flash card list -- this will create tons of confusion and ruin the point of the find command where I want to learn specific parts of words. If you're confused at this point why I used the word "twin", so is the user -- because the German translation of "twin" is "Zwilling".

Without loss of generality, this issue also applies to searching for translations and getting "original word" results. For example, I could want to learn feminine German nouns, so I search for "die", but then my flashcard list shows "the mother" (correct), "the duck" (correct), but also "biodiesel" (????), I would be confused and annoyed that the find function isn't helpful for me.