search

kokspflanze / ZfcTwig

Laminas / Zend Framework 2/3 Module that provides a Twig 1/2/3 rendering strategy
BSD 3-Clause "New" or "Revised" License
14 stars 5 forks source link

#87 #65 #68 #108 recursive addChild support #10

Closed kusmierz closed 7 years ago

kusmierz commented 7 years ago

Would be awesome to use your fork, but I need this fix also. Could you merge it please?

kokspflanze commented 7 years ago

@kusmierz i will check it friday/saturday, atm in vacation, hope this is okay=]

kokspflanze commented 7 years ago

@kusmierz i hope you can work, with dev-master, i will work on some more tests for next main version

kusmierz commented 7 years ago

Great, thanks @kokspflanze!

kusmierz commented 7 years ago

Hm, unfortunately I have to wait for 1.4.x release, as I'm using zf 2.x...

kokspflanze commented 7 years ago

i will see what i can do tomorrow for 1.x release with this kind of fix.

have also to create a test for that.

kokspflanze commented 7 years ago

@kusmierz check https://github.com/kokspflanze/ZfcTwig/releases/tag/1.4.2

kusmierz commented 7 years ago

Thanks. Had some problem with FlashMessanger view helper (service alias can't create service), unfortunately it isn't just in-place replacement. Will look at it later.