kokutele / mediasoup-exporter

mediasoup exporter for prometheus
6 stars 1 forks source link

Use `counter` type instead of `gauge` for metrics #4

Open atmosx opened 3 years ago

atmosx commented 3 years ago

Hi!

I noticed that most metrics are set as type Gauge, however most series seem to fall in the monotonically increasing counter category. Having these metrics as counters enables the use or functions like rate(), etc. These functions can still be applied, but Grafana and other tools will complain about it. The naming scheme is a bit counter-intuitive as well. AFAIK the common practice is to use _total or _count for counters and _sum for Gauges.

Thanks again for your hard work on this!