search

kokuwaio / helm-maven-plugin

Simple plugin to package helm charts
MIT License
81 stars 55 forks source link

Helm output is logged as `ERROR` for successful `helm:push` (unsolved helm issue) #275

Open koenverwimp opened 1 year ago

koenverwimp commented 1 year ago

AWS ECR now supports pushing helm charts (see https://docs.aws.amazon.com/AmazonECR/latest/userguide/push-oci-artifact.html). I tried to push a helm with the plugin but the "oci://" protocol is not supported.

[ERROR] Failed to execute goal com.kiwigrid:helm-maven-plugin:5.5:upload (default-upload) on project ams-docker: Error uploading /Users/.../....tgz to oci://xxxxxx.dkr.ecr.eu-west-1.amazonaws.com: unknown protocol: oci -> [Help 1]

sschnabe commented 1 year ago

This was implemented with version 6.1.0 with #120. You are using the old maven coordinates, please use: mvn io.kokuwa.maven:helm-maven-plugin:6.6.1:push

koenverwimp commented 1 year ago

I think i might just not filled in the correct repo type, but i only see these 3 options. Keeping chartmuseum still gives the same issue. What type should i use for AWS ECR

Failed to execute goal io.kokuwa.maven:helm-maven-plugin:6.6.1:upload (default-upload) on project ams-docker: Upload failed.: unknown protocol: oci -> [Help 1]

public enum RepoType { CHARTMUSEUM, ARTIFACTORY, NEXUS }

sschnabe commented 1 year ago

Please see push integration test: https://github.com/kokuwaio/helm-maven-plugin/blob/main/src/it/push-with-auth-from-settings/pom.xml#L34-L37

koenverwimp commented 1 year ago

Sorry to disturb you further about this:

In the link they don't provide the "type" tag but i keep getting issues with this Repository type field.

Failed to execute goal io.kokuwa.maven:helm-maven-plugin:6.6.1:upload (default-upload) on project ams-docker: Execution default-upload of goal io.kokuwa.maven:helm-maven-plugin:6.6.1:upload failed: Repository type missing. Check your plugin configuration. -> [Help 1]

koenverwimp commented 1 year ago

Ah wait, i might be doing helm:upload instead of helm:push.

koenverwimp commented 1 year ago
image

It looks strange ... i get the error but that the maven succeed and the build is green. The helm is even pushed successfully.

sschnabe commented 1 year ago

Thx, is wasn't aware of this.

sschnabe commented 1 year ago

Not an issue of this maven plugin, this comes from helm: https://github.com/helm/helm/issues/11533

steromano87 commented 5 months ago

@koenverwimp @sschnabe a similar issue (successful login message marked as an error) happens also when logging in into an OCI registry