search

kokuwaio / helm-maven-plugin

Simple plugin to package helm charts
MIT License
82 stars 55 forks source link

Upload path created always has version first #286

Closed Pallavi810 closed 1 year ago

Pallavi810 commented 1 year ago

Is this a request for help no

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

Environment (plugin version, maven version, OS, ...): Plugin version is 6.4.0

What happened: The class UploadMojo only uses project group Id as the path where it uploads and then appends with version only. Instead the path should be groupid+artifactid inside of white a chart should be present. Otherwise it's not organized.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible): Just upload any chart to artifactory. Anything else we need to know:

sschnabe commented 1 year ago

@Pallavi810 in #287 i've added a flag to use the artifactId instead of groupId or in combination with groupId. Please verify if #287 matches your requirements.

Pallavi810 commented 1 year ago

Yes this works

Pallavi810 commented 1 year ago

Could you please create a release version for the same

sschnabe commented 1 year ago

Release with 6.7.0