search

kolber / stacey

Cheap & easy content management
http://staceyapp.com
MIT License
1.04k stars 131 forks source link

Upgrade Twig to 1.13.1 #91

Open itskingori opened 11 years ago

itskingori commented 11 years ago
mjau-mjau commented 11 years ago

Did you manage to upgrade twig? I am missing several functionality from newer TWIG

itskingori commented 11 years ago

@suncat100 Yes I was and have been using it on my site without any hiccups. Have a look at my fork which has the changes (I did send a pull request hence this thread). The commits are listed above.

This was in response to an issue filed (#77) but I guess @kolber hasn't had the chance to have a look at it yet.

The only thing that I'd caution you against is a bunch of lines I commented out because they caused a "Attribute callable does not exist for Node" error ... I can't explain why this gets rid of the error since I don't have the context of Stacey's inner workings.

Please note that I submitted this about 3 months ago and haven't updated my fork with the upstream and I can see he has submitted more commits since then.

mjau-mjau commented 11 years ago

@itsmrwave nice1 I will look into it ...

o-l-e commented 9 years ago

Hey @kolber hope you are all good!

Would it be possible to merge this pull, if it looks ok? We are a gang trying to get the Stacey snippets page going, and some of the snippets require some of the filters in a later version of Twig :)

Sorry for nagging at you.

Discussion going on here: https://github.com/kolber/stacey/issues/97 Snippets (join in people) here: https://github.com/kolber/Stacey-Snippets