search

kolbyjack / MMM-MonthlyCalendar

MIT License
30 stars 20 forks source link

`hidePrivate` option from the default calendar module is not respected #9

Closed adamhassel closed 2 years ago

adamhassel commented 2 years ago

Steps to reproduce:

  1. Create a Private event in a configured calendar
  2. Set hidePrivate: true on the default calendar config

Expected results:

Private events are not shown in either the monthly view or in the default calendar display

Actual results:

Private events are shown in the monthly view, but hidden (as they should be) in the default calendar display

adamhassel commented 2 years ago

Bah, I realize that this is caused by a design decision (I don't want to call it a bug, because I'm not sure if it is in fact intentional or not) in the default calendar, which broadcasts all events prior to applying the hidePrivate (and other) logic...

kolbyjack commented 2 years ago

https://github.com/MichMich/MagicMirror/pull/2787 was merged, this should work on the develop branch now