search

kolbyjack / MMM-Wallpaper

MagicMirror module to display wallpapers from various online sources
https://magicmirror.builders/
MIT License
99 stars 31 forks source link

Flickr group issue / conflict with other module #44

Closed bkosk closed 2 years ago

bkosk commented 2 years ago

I'm having two separate issues: one more with your module, the other may be out of bounds.

First, I'm unable to load Flickr group photos (https://www.flickr.com/groups/1059982@N21/pool/). My config code is: module: "MMM-Wallpaper", psoition: "fullscreen_below", config: { source: "flickr-group:1059982@N21", slideInterval: 10*60*1000 } All I get is a black background. If I change the source to "bing" images load just fine.

The second issue is when I also load MMM-NetworkConnection (https://github.com/slametps/MMM-NetworkConnection): it seems to override MMM-Wallpaper. I only get a black screen (no matter the source). When I comment out NetworkConnection module Wallpaper works. I'm just not smart enough to look at each of your sources to determine where the conflict is. Thank you in advance, and thanks for developing and sharing your work!

kolbyjack commented 2 years ago

For the flickr issue, you probably need to set flickrHighRes: false in your config. Some time ago, they changed the way they generate the high-res urls, and I've never gotten around to figuring out how to fetch them now.

I really don't know how MMM-NetworkConnection could be interfering. Does it show when you enable it, or is the screen completely black? Perhaps it's an issue with an invalid config when you have them both?

bkosk commented 2 years ago

Thanks for the quick reply. Turning off high-res worked! Thank you!

As for NetworkConnection: when I enable it and yours, no wallpapers load. It's just a black background, but all other modules work and show properly. Re-Edit: looks like after doing a fresh install of Network connection resolved the issue. Now everything is displaying properly. Nope: back to only one of the two working. I temporarily had Wallpaper working when I moved NetworkConnection out of the bottom_bar, but NetworkConnection would only display "loading".

kolbyjack commented 2 years ago

MMM-NetworkConnection depends on speedtest-net, which is patching the core node.js https.request method, and something about its patching isn't playing nicely with MMM-Wallpaper.

kolbyjack commented 2 years ago

It looks like https://github.com/ddsol/speedtest.net doesn't depend on agent-base anymore, and agent-base doesn't even monkeypatch https.request anymore, so I think this is a bug for MMM-NetworkConnection to update their speedtest-net version

bkosk commented 2 years ago

Okay - I see. Thank you for your help!

kolbyjack commented 2 years ago

I added a package.json with a dependency on the request module, try updating to latest (you'll have to run npm install in the module directory now) and it should work with MMM-NetworkConnection now.