search

kolbyjack / MMM-Wallpaper

MagicMirror module to display wallpapers from various online sources
https://magicmirror.builders/
MIT License
99 stars 31 forks source link

The Wallpaper is shown twice #46

Closed MacG-DD closed 2 years ago

MacG-DD commented 2 years ago

If I set position: "fullscreen_below" at the config.js then the modul is shown twice. One at all at the bottom (at the top of the DIV list) and the second time inside the fullscreen region.

I didn't notice this in operation, I found it in the page source code of the MagicMirror. So it shows the background twice. This should lead to more memory usage.

A quick work-a-round - don't use the position line.

kolbyjack commented 2 years ago

The wallpaper isn't actually shown twice. If you look at the div inside the fullscreen region, it only has an empty span inside. I've removed position from the example config to avoid the confusion.

MacG-DD commented 2 years ago

Thanks for the clarification.

But it would be better to use the regions. Then someone can hide the module for some reason with the MMM-RemoteControl. Currently, it is always on.

kolbyjack commented 2 years ago

I originally did use the regions, and there were weird sizing issues sometimes, which made them hard to reproduce/debug