I added Pexels Support! - Githubissues

kolbyjack / MMM-Wallpaper

MagicMirror module to display wallpapers from various online sources

https://magicmirror.builders/

MIT License

99 stars 31 forks source link

I added Pexels Support! #6

Closed earlman closed 4 years ago

earlman commented 4 years ago

Hi! Excuse me if I made an amateur mistake with this pull request. I’ve been coding for a while, but I’ve never worked on open source projects before :P

But anyways I spent a bit of time figuring out your work on this Module and I added Pexels support that’s hopefully inline with the way you’ve organized your work on MMM-Wallpapers.

couple things to note:

I had changed the module to MMM-wallpaper-np-dash while I did my own work on this, so commit c3b0ce5 is not necessary for production
This adds 2 config options:
- pexels_key is required for use
- pexels_search customizes the request url

Hopefully you like my work! A couple people from the MM forum are interested in my setup, which is what motivated me to send in this pull request, so it’d be great if this could get through :D

kolbyjack commented 4 years ago

Merged manually in d9d014c. Reformatting a file and changing all of the whitespace makes it harder to accept a change, but this was small enough that it wasn't a terrible issue. In the future, even if it doesn't match your personal style, please try to keep the formatting consistent with what the upstream project uses.