search

kolbyjack / MMM-Wallpaper

MagicMirror module to display wallpapers from various online sources
https://magicmirror.builders/
MIT License
99 stars 31 forks source link

Follow up PR: fix(MMM-Wallpaper NASA): :bug: As discussed in the NASA PR, some nece… #78

Closed tderflinger closed 1 year ago

tderflinger commented 1 year ago

Hi Jon,

thanks for merging my previous PR.

As discussed in the previous PR, here is a follow up with the image filtering and a shorter caption text. Regarding the API key, I think it normally is not necessary and would not bring better image quality. I might add the API key in the future, though.

Regards, -Thomas

kolbyjack commented 1 year ago

Regarding the API key, I think it normally is not necessary and would not bring better image quality. I might add the API key in the future, though.

I made a bad assumption about this, there's no api key required for the higher resolution images with this service, you have to fetch each image's manifest (at /asset/{nasa_id}) and parse the returned collection. Unfortunately, I don't see a way to fetch multiple manifests in a single request, and the returned data doesn't contain the image sizes for each url.