search

kolbyjack / MMM-Wallpaper

MagicMirror module to display wallpapers from various online sources
https://magicmirror.builders/
MIT License
104 stars 31 forks source link

orientation label ignored on Reddit #9

Closed hweigel closed 4 years ago

hweigel commented 4 years ago

Using the MM in portrait mode. When setting orientation to either "vertical" or "auto", the module still pulls and displays landscape images from the subreddit. Tested with multiple channels, e.g. r/EarthPorn, r/MostBeautiful. Please advise.

kolbyjack commented 4 years ago

Is your expectation that it would skip landscape oriented images from reddit? "vertical" and "auto" currently only mean something to the bing source, since it provides 1920x1080 and 1080x1920 versions of each background.

hweigel commented 4 years ago

Yeah, that kinda was what I expected. I'll stick with bing until I'll grow the stones to fork your module. Maybe you could add that detail regarding orientation only working for bing to the Readme.md.

Last but not least, a) great module and b) thx for getting back to me so quickly.