search

kolesnikovav / vuetify-toolkit

The set of additional vuetify components
MIT License
28 stars 5 forks source link

VDataGridSelect #16

Open Mashiane opened 3 years ago

Mashiane commented 3 years ago

Hi there

Thanks for the updates you have made. If you dont mind me highlighting some few issues again.

  1. Multiple mode: When you click on the select, detect if the data-table is open, if the data-table is open then close it. Currently opening of the data-table happens when you click the select, but then you have to click the close button to close it.

  2. Multiple mode: Add an Ok/Apply button at the bottom left of the data-table. This Ok button should show when you have activated "multiple" mode. Usually one selects items on the left and now having to scroll to the right to close the data-table is additional work. This ok/apply button will close the data-table once a user has made their selection and clicked "Ok"

  3. No two way binding when one actually clicks the "delete" button on the chip itself. This works when items are de-selected from the data-table not the other way round.

VDataGridSelect

Mashiane commented 3 years ago
  1. Clicking the clearable button, should also clear the selected items on the data-table.
Mashiane commented 3 years ago
  1. The v-model returns objects whilst the select return item-values. Can you please look at that. For example I have a label here that is supposed to show the vmodel values in {{ selItems }}, when an item is selected, its object is returned as demonstrated. The values in the select are Ok though.

VDataGridSelect

  1. The location of the data-table should always syncronise itself with the select. For example in the gif above, the select moved down whilst the data-table did not and thus sat itself on top of the select.

Thanks

kolesnikovav commented 3 years ago

@Mashiane Good day. Thank You for interesting suggestions!