kolide / fleet

A flexible control server for osquery fleets
https://kolide.com/fleet
MIT License
1.1k stars 260 forks source link

passing osquery configuration to launcher #1584

Open groob opened 7 years ago

groob commented 7 years ago

Moving from code review in #1582

The current implementation of the launcher is somewhat opinionated about osquery config, so when the configuration endpoint was added in https://github.com/kolide/fleet/pull/1544/files#diff-57894187d53a170dbc47ebddb3139466R54 the following change was made:

    // Launcher manages plugins so remove them from configuration if they exist.
    for _, optionName := range []string{"distributed_plugin", "logger_plugin"} {
        if _, ok := config.Options[optionName]; ok {
            delete(config.Options, optionName)
        }
    }

Is it necessary to remove those options? Especially if the user wants to configure multiple logger_plugins.

// cc @marpaia @zwass

marpaia commented 7 years ago

The reason why this is here is because the default configuration options in fleet specify that the tls logger and distributed plugins should be used. This is problematic for the launcher because obviously the launcher should continue to use the kolide_grpc plugins, not tls. This was added as a quick fix, but it is obviously not a sustainable solution to this problem.