kolide / launcher

Osquery launcher, autoupdater, and packager
https://kolide.com/launcher
Other
506 stars 103 forks source link

Launcher's internal logging framework is confusing #1082

Closed directionless closed 10 months ago

directionless commented 1 year ago

Today, launcher has a single logging mechanism. Logs of info and higher go into the system log facilities, and logs of debug and higher are additionally mirrored into the launcher root directory. This evolved a bit over time, and while it kinda works, it also is super confusing.

As we've grown, it's become clear that most devices are not being used by the developers. This means we should be thoughtful about what we log out to the computer. There is a clear difference between something we want to log to the computer owner, or site admin. Vs what we want to log for us developers or to aid a future support interaction.

directionless commented 1 year ago

slog is the new structured logging in golang.org/x. At first glance, it feels very similar to how our existing go-kit logger works. I think we should consider moving to it. (Somewhat related, there's an interesting contribution to allow slog to output to various backends. https://github.com/galecore/xslog I don't think these are immediately useful, but good to see examples)

directionless commented 10 months ago

Work has become to improve logging. I don't think we need this issue