kolide / launcher

Osquery launcher, autoupdater, and packager
https://kolide.com/launcher
Other
500 stars 99 forks source link

Desktop looks like it might burn CPU if the required gnome extension is missing #1326

Open directionless opened 10 months ago

directionless commented 10 months ago

I'm not wholly sure here, but some diagnosing on slack makes me think desktop can burn a bunch of CPU if the required gnome extension is missing. We shouldn't burn CPU. Probably shouldn't start desktop.

Not sure how to detect this. I don't love needing another exec.

Relates to #1325

tomaspinho commented 9 months ago

I'm seeing this issue on all of my Ubuntu-based machines: 23.04, 23.10 beta, etc.

It just pegs a single CPU core to 100% on every login, kicking the fan speeds all the way to max and staying there.

I've resorted to SIGKILL'ing the process from htop on every login :/

James-Pickett commented 9 months ago

@tomaspinho, we've seen this issue happen before when ubuntu-appindicators is disabled. Can you check to see if it's enabled using gnome-extensions show ubuntu-appindicators@ubuntu.com if not enabled can you enable with gnome-extensions enable ubuntu-appindicators@ubuntu.com?

dooferlad commented 1 month ago

Shouldn't the systemd unit have the target WantedBy=xdg-desktop-autostart.target for the desktop launcher? I also see a CPU getting eaten by the launcher sometimes and I have he appindicator extension enabled, so it isn't just that.

 /usr/lib/systemd/system/launcher.kolide-k2.service
[Unit]
Description=The Kolide Launcher
After=network.service syslog.service

[Service]
ExecStart=/usr/local/kolide-k2/bin/launcher \
-config \
/etc/kolide-k2/launcher.flags
Restart=on-failure
RestartSec=3
CPUQuota=50% # limit the impact of this issue until it is resolved

[Install]
WantedBy=xdg-desktop-autostart.target # don't start until the desktop has loaded