search

kolide / launcher

Osquery launcher, autoupdater, and packager
https://kolide.com/launcher
Other
503 stars 98 forks source link

Don't select launcher version under v1.4.1 on stable #1559

Closed RebeccaMahany closed 7 months ago

RebeccaMahany commented 7 months ago

If a user has a recent launcher version (e.g. 1.4.4) in their legacy autoupdate library and this recent launcher version is not the current stable (e.g. we roll back from 1.4.4 to 1.4.2) and their new autoupdate library has versions that are only older than 1.4.1 (e.g. 1.3.2), they can get stuck in a loop on startup:

  1. The older installed version of launcher bootstraps itself to the newest version in the legacy library v1.4.4
  2. v1.4.4 recognizes that it's not on the the release version v1.4.2, so falls back to loading the newest version in the new autoupdate library, v1.3.2
  3. v1.3.2 does not know it should use the new autoupdate library yet, so it goes back through and bootstraps itself to the newest version in the legacy library, v1.4.4
  4. Repeat 2-3
RebeccaMahany commented 7 months ago

@directionless yes I think that would be a good idea!