kolide / launcher

Osquery launcher, autoupdater, and packager
https://kolide.com/launcher
Other
500 stars 99 forks source link

Refactor runAsUser into tablehelper package #1653

Closed Micah-Kolide closed 3 months ago

Micah-Kolide commented 3 months ago

Cleaning up the runAsUser idiom I was using in a couple of places for the table generates.

RebeccaMahany commented 3 months ago

I don't feel strongly about it either way. I think enforcing the timeout/logging is a plus, but I'm not terribly worried about not enforcing either since we do a good job including that in the first place and/or requesting it in code review.