kolide / launcher

Osquery launcher, autoupdater, and packager
https://kolide.com/launcher
Other
505 stars 100 forks source link

run osq runtime tests on windows #1665

Closed James-Pickett closed 6 months ago

James-Pickett commented 6 months ago

This PR enables osq runtime tests on windows. When running the tests locally on windows, I've only been able to get them to work when running as administrator. I think that's okay?

Thera are a few tests added to runtime_posix_test.go that would not run or were flakey on windows.

I spent a few hours trying to figure out why the TestRestart test would not work consistently on windows, but I was stumped. If anybody has an ideas there, it would be great.