kolide / launcher

Osquery launcher, autoupdater, and packager
https://kolide.com/launcher
Other
500 stars 99 forks source link

Make launcher run ID available in knapsack #1706

Open RebeccaMahany opened 2 months ago

RebeccaMahany commented 2 months ago

Launcher has a "run ID" that is currently added to all log messages. This run ID is only available inside the multislogger itself, and is created during new multislogger instantiation. We'd like to be able to access this run ID elsewhere, e.g. to report the current run ID up to k2 during startup, so we want to move it into launcher's knapsack. The instantiation of run ID inside multislogger.New also has the side effect that the same launcher run has multiple run IDs across different multisloggers -- for example, Windows event logs and debug.json logs will have different run IDs for the same run. Ideally, each time launcher runs, it should have a singular, unique run ID that it can access from the knapsack.

Notes for implementation: