Launcher on Windows won't display correct version in some places

[RebeccaMahany]

Because we do not update the app registry when we load a new update for launcher, in some places (e.g. in Apps & Features) the launcher version will display as the original install version instead of the currently running version. This is misleading for users and also potentially confusing, since it will conflict with the correct version displayed in the launcher menu.

We should research our options for keeping the app registry info, including version, accurate after launcher upgrades.

---

Further details:

• Launcher on Windows (as on other OSes) performs updates by downloading the latest binary to the update folder (on Windows, C:\Program Files\Kolide\Launcher-kolide-k2\bin\launcher.exe-updates), checking to see if there is a valid binary in that update folder, and running it if so. These are launcher.exe binaries and not MSIs.
• If we shipped an updated MSI instead, app registry info would be updated automatically. However, this is a non-trivial change given how we currently build our MSIs, and we aren't certain about the stability of this option.
• Launcher versions can be viewed in the Registry Editor under Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{<GUID>}, where <GUID> corresponds to a GUID from a launcher installation, as well as under Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Kolide\Launcher\kolide-k2\Version.
• The GUID is generated here: https://github.com/kolide/launcher/blob/main/pkg/packagekit/package_wix.go#L185

[directionless]

This is an issues on all the platforms. On the linux ones, the packaging tool (rpm, dpkg, pacman, ...) will have the old version. We do get questions about that very occasionally.

On macOS the pkg versions will be wrong, but no on e looks at that.

[directionless]

I should also mention that I'm somewhat against update strategies that involve execing msi or other packaging tools. That is too failure prone