search

kolinger / rd-usb

Web GUI for RuiDeng/Riden USB testers (UM34C, UM24C, UM25C, TC66C)
GNU General Public License v3.0
231 stars 30 forks source link

Feature Request: UI - Dark Mode #20

Closed dmberrycom closed 2 years ago

dmberrycom commented 2 years ago

Add an option to switch UI from a White to Black theme to save my eyes :)

kolinger commented 2 years ago

Hello, dark theme was added. You can find it in Setup tab. Available in 1.12.0 version - here.

It is sufficient?

dmberrycom commented 2 years ago

Thanks, I think there a few issues with the dark bootstrap theme.

I started a fork to look at adding an additional theme and a few changes. I used the dark theme as the baseline but it seems that the source for the dark theme is not quite the same as the default(light) theme.

The dark theme has issues with the navbar expanding and hiding parts of the UI and also the graphs are only using small proportion of the screen height in dark mode.

kolinger commented 2 years ago

Hi, issues are expected but it shouldn't be hard to fix.

Navigation issue: I did tweak the navigation a bit - now it fits so it doesn't expand when not needed. Also even if it does expand it will not hide content as before. This should fix the navigation issue. This will be included in next version.

Graph height issue: I wasn't able to reproduce this issue. In my testing graph height is acceptable and identical in light and dark theme. Here I need your help. If I can't see the problem then I can't fix it, but you can give me more information, then I could perhaps reproduce this issue on my end or at least I could understand the issue more. Can you provide screenshot? Do you use CLI+external web browser or standalone version of rd-usb?

dmberrycom commented 2 years ago

Great,

Absolutely happy to provide more information would you like to push the update with the navigation fix, I will then re-test against that.

So far I've just been doing the testing in CLI+external web browser, but I could also try it with the standalone.

kolinger commented 2 years ago

Hi, you can get temporary build with fixed navigation here.

No need to test standalone application. Keep using what you want. They are pretty similar, nearly identical. In case of external browser it would be useful to know what browser it is (Chrome, Firefox, ...) and what resolution are you using.

kolinger commented 2 years ago

New themes and fixes available in 1.13.0 - here.

dmberrycom commented 2 years ago

Super,

Thanks for such a handy tool.