search

kolinkrewinkel / KKGridView

Deprecated: Grid view library for iOS.
https://github.com/kolinkrewinkel/KKGridView
Other
821 stars 151 forks source link

add _deselectAll to private interface #123

Closed adamvduke closed 12 years ago

adamvduke commented 12 years ago

_deselectAll is called before it is declared. At best this causes a warning. With certain versions of the compiler this causes a build failure.

jonsterling commented 12 years ago

Thanks for the contributions! I'll try to review them tonight.

Thanks again, Jon

Sent from my iPhone

On Apr 2, 2012, at 12:27 PM, Adam Dukereply@reply.github.com wrote:

_deselectAll is called before it is declared. At best this causes a warning. With certain versions of the compiler this causes a build failure.

You can merge this Pull Request by running:

git pull https://github.com/appRenaissance/KKGridView fix-deselect-all-error

Or you can view, comment on it, or merge it online at:

https://github.com/kolinkrewinkel/KKGridView/pull/123

-- Commit Summary --

  • add _deselectAll to private interface

-- File Changes --

M KKGridView/KKGridView.m (1)

-- Patch Links --

https://github.com/kolinkrewinkel/KKGridView/pull/123.patch https://github.com/kolinkrewinkel/KKGridView/pull/123.diff

Reply to this email directly or view it on GitHub: https://github.com/kolinkrewinkel/KKGridView/pull/123

adamvduke commented 12 years ago

Sounds good Jon. Thanks for taking a look. We are using the grid in a client app that should be in the store soon. I was trying to update the version we are using but didn't realize how fast the development was going and how far behind master our fork had gotten. I came across these few small issues yesterday while updating.