search

koliveira15 / nx-sonarqube

A Nx plugin that scans projects using SonarQube / SonarCloud.
MIT License
52 stars 21 forks source link

Support sonarqube-scanner v4 #118

Closed Tommy228 closed 1 week ago

Tommy228 commented 1 month ago

Which scope/s are relevant/related to the feature request?

@koliveira15/nx-sonarqube

Information

sonarqube-scanner has a new major version (v4) however nx-sonarqube does not support it currently. The executor fails with the following error

TypeError: sonarQubeScanner.async is not a function
    at node_modules/@koliveira15/nx-sonarqube/src/executors/scan/utils/utils.js:154:48
    at Generator.next (<anonymous>)
    at fulfilled (node_modules/tslib/tslib.js:166:62)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

I think async needs to be replaced with scan.

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to provide this feature

gcko commented 1 month ago

@Tommy228 once PPR #117 is checked and merged into main, I can take a look at updating the version of sonarqube-scanner to latest. It will require updates to the tests as well