search

koliveira15 / nx-sonarqube

A Nx plugin that scans projects using SonarQube / SonarCloud.
MIT License
50 stars 20 forks source link

PeerDependency issue with @phenomnomnominal/tsquery #122

Open gcko opened 3 hours ago

gcko commented 3 hours ago

If possible, please provide a reproduction repository you discovered this bug in.

https://github.com/koliveira15/nx-sonarqube/blob/4903a7412ba88224703356095d82274bf6be4847/packages/nx-sonarqube/package.json#L16

Which area/package is the issue in?

@koliveira15/nx-sonarqube

Description

Peer dependencies are not properly resolving, causing npx nx run-many -t sonar to fail

If applicable, please provide the Nx report

No response

Please provide the exception or error you saw

 WARN  Issues with peer dependencies found
.
└─┬ @koliveira15/nx-sonarqube 4.2.0
  └── ✕ unmet peer @phenomnomnominal/tsquery@6.1.3: found 5.0.1

Other information

the peer dependency probably needs to be more lenient. Since the breaking change was to the move to version 6 of the dependency, I would suggest "@phenomnomnominal/tsquery": ">= 6", would be perfectly fine

I would be willing to submit a PR to fix this issue

gcko commented 3 hours ago

Also note: the current workaround for users is to add "@phenomnomnominal/tsquery": "6.1.3" to your package.json devDependencies and it will work just fine 👍