Please check if your PR fulfills the following requirements:
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Configuration related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
Which package are you modifying?
[x] @koliveira15/nx-sonarqube
[ ] docs-site
What is the current behavior?
For now, we can only ignore implicit dependencies. While auditing many repositories, it pushes the app sources and its dependencies that may result in duplicate reports.
Closes #66
What is the new behavior?
This PR allows us to ignore all project dependencies.
Does this PR introduce a breaking change?
[ ] Yes
[x] No
Other information
I made it simple but I think a better way to implement this would be to use an enum like this :
skipDeps?: 'none' | 'implicit' | 'all'
Also, as the getDependentPackagesForProject function is internal, without modifying a bunch of code, I couldn't test the branch properly
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
For now, we can only ignore implicit dependencies. While auditing many repositories, it pushes the app sources and its dependencies that may result in duplicate reports.
Closes #66
What is the new behavior?
This PR allows us to ignore all project dependencies.
Does this PR introduce a breaking change?
Other information
I made it simple but I think a better way to implement this would be to use an enum like this :
Also, as the getDependentPackagesForProject function is internal, without modifying a bunch of code, I couldn't test the branch properly