koliveira15 / nx-sonarqube

A Nx plugin that scans projects using SonarQube / SonarCloud.

MIT License

51 stars 21 forks source link

Replace branches flag with branch string property in schema #77

Closed koliveira15 closed 8 months ago

koliveira15 commented 8 months ago

One of the original features of the plugin was to to determine the branch for the user, but it has become apparent that the plugin cannot account for every CI provider and how it determines the current branch. This PR replaces the branches flag with a branch string property, and it is up to the consumer to pass said property with their nx command:

npx nx sonar my-app --branch="feature/my-branch"

nx-cloud[bot] commented 8 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3b6b7dfa924ba34c13994283be72f4714a8fe05d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

- [`nx affected -t build`](https://cloud.nx.app/runs/TdgTAcciCD?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.