search

kolkov / ngx-gallery

A simple responsive native gallery component for Angular 8+.
https://ngx-gallery.kolkov.ru/
MIT License
115 stars 56 forks source link

ivy-ngcc failing with No suitable injection token for parameter 'sanitization' of class 'NgxGalleryPreviewComponent'. #2

Closed uzumakinaruto123 closed 4 years ago

uzumakinaruto123 commented 4 years ago

"postinstall": "ivy-ngcc"

failing with

Compiling @kolkov/ngx-gallery : fesm2015 as esm2015
No suitable injection token for parameter 'sanitization' of class 'NgxGalleryPreviewComponent'.
no type or decorator

Angular Version

Angular CLI: 8.3.20
Node: 10.15.3
OS: win32 x64
Angular: 8.2.14
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... platform-server, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.803.20
@angular-devkit/build-angular     0.803.20
@angular-devkit/build-optimizer   0.803.20
@angular-devkit/build-webpack     0.803.20
@angular-devkit/core              8.3.20
@angular-devkit/schematics        8.3.20
@angular/cli                      8.3.20
@angular/http                     7.2.15
@ngtools/webpack                  8.3.20
@schematics/angular               8.3.20
@schematics/update                0.803.20
rxjs                              6.5.3
typescript                        3.5.3
webpack                           4.39.2
kolkov commented 4 years ago

Hi! Provide an repo with this error please.

kolkov commented 4 years ago

https://ngx-gallery.kolkov.ru/ - demo built with Ivy 9.0.0-rc.6

uzumakinaruto123 commented 4 years ago

I thought I had messed dependencies, so I generated a new angular project which was with 7.x version.

I then decided to ng update, which updates the project to 8.x.

Repo: https://github.com/uzumakinaruto123/ngx-gallery-ivy-repro

Steps:

1. ng new
2. ng update --all --force
3. npm install typescript@3.5.3 --save-dev
4. "angularCompilerOptions": {
    "enableIvy": true,
    "allowEmptyCodegenFiles": true
  }
5. "build": {
          "options": {
            ...
            "aot": true,
          }
        }
6. "postinstall": "ivy-ngcc
7. npm i

Output:


> ivy-ngcc

Compiling @angular/animations : fesm2015 as esm2015
Compiling @angular/animations : fesm5 as esm5
Compiling @angular/animations : esm2015 as esm2015
Compiling @angular/animations : esm5 as esm5
Compiling @angular/animations : main as umd
Compiling @angular/core : fesm2015 as esm2015
Compiling @angular/core : fesm5 as esm5
Compiling @angular/core : esm2015 as esm2015
Compiling @angular/core : esm5 as esm5
Compiling @angular/core : main as umd
Compiling @angular/animations/browser : fesm2015 as esm2015
Compiling @angular/animations/browser : fesm5 as esm5
Compiling @angular/animations/browser : esm2015 as esm2015
Compiling @angular/animations/browser : esm5 as esm5
Compiling @angular/animations/browser : main as umd
Compiling @angular/animations/browser/testing : fesm2015 as esm2015
Compiling @angular/animations/browser/testing : fesm5 as esm5
Compiling @angular/animations/browser/testing : esm2015 as esm2015
Compiling @angular/animations/browser/testing : esm5 as esm5
Compiling @angular/animations/browser/testing : main as umd
Compiling @angular/common : fesm2015 as esm2015
Compiling @angular/common : fesm5 as esm5
Compiling @angular/common : esm2015 as esm2015
Compiling @angular/common : esm5 as esm5
Compiling @angular/common : main as umd
Compiling @angular/common/http : fesm2015 as esm2015
Compiling @angular/common/http : fesm5 as esm5
Compiling @angular/common/http : esm2015 as esm2015
Compiling @angular/common/http : esm5 as esm5
Compiling @angular/common/http : main as umd
Compiling @angular/common/http/testing : fesm2015 as esm2015
Warning: Unknown member type: "[key: string]: (data: any) => void;
Compiling @angular/common/http/testing : fesm5 as esm5
Warning: Unknown member type: "[key: string]: (data: any) => void;
Compiling @angular/common/http/testing : esm2015 as esm2015
Warning: Unknown member type: "[key: string]: (data: any) => void;
Compiling @angular/common/http/testing : esm5 as esm5
Warning: Unknown member type: "[key: string]: (data: any) => void;
Compiling @angular/common/http/testing : main as umd
Compiling @angular/platform-browser : fesm2015 as esm2015
Compiling @angular/platform-browser : fesm5 as esm5
Compiling @angular/platform-browser : esm2015 as esm2015
Compiling @angular/platform-browser : esm5 as esm5
Compiling @angular/platform-browser : main as umd
Compiling @angular/forms : fesm2015 as esm2015
Compiling @angular/forms : fesm5 as esm5
Compiling @angular/forms : esm2015 as esm2015
Compiling @angular/forms : esm5 as esm5
Compiling @angular/forms : main as umd
Compiling @angular/platform-browser/animations : fesm2015 as esm2015
Compiling @angular/platform-browser/animations : fesm5 as esm5
Compiling @angular/platform-browser/animations : esm2015 as esm2015
Compiling @angular/platform-browser/animations : esm5 as esm5
Compiling @angular/platform-browser/animations : main as umd
Compiling @angular/core/testing : fesm2015 as esm2015
Compiling @angular/core/testing : fesm5 as esm5
Compiling @angular/core/testing : esm2015 as esm2015
Compiling @angular/core/testing : esm5 as esm5
Compiling @angular/core/testing : main as umd
Compiling @angular/platform-browser-dynamic : fesm2015 as esm2015
Compiling @angular/platform-browser-dynamic : fesm5 as esm5
Compiling @angular/platform-browser-dynamic : esm2015 as esm2015
Compiling @angular/platform-browser-dynamic : esm5 as esm5
Compiling @angular/platform-browser-dynamic : main as umd
Compiling @angular/platform-browser/testing : fesm2015 as esm2015
Compiling @angular/platform-browser/testing : fesm5 as esm5
Compiling @angular/platform-browser/testing : esm2015 as esm2015
Compiling @angular/platform-browser/testing : esm5 as esm5
Compiling @angular/platform-browser/testing : main as umd
Compiling @angular/compiler/testing : fesm2015 as esm2015
Compiling @angular/compiler/testing : fesm5 as esm5
Compiling @angular/compiler/testing : esm2015 as esm2015
Compiling @angular/compiler/testing : esm5 as esm5
Compiling @angular/compiler/testing : main as umd
Compiling @angular/platform-browser-dynamic/testing : fesm2015 as esm2015
Compiling @angular/platform-browser-dynamic/testing : fesm5 as esm5
Compiling @angular/platform-browser-dynamic/testing : esm2015 as esm2015
Compiling @angular/platform-browser-dynamic/testing : esm5 as esm5
Compiling @angular/platform-browser-dynamic/testing : main as umd
Compiling @angular/common/testing : fesm2015 as esm2015
Compiling @angular/common/testing : fesm5 as esm5
Compiling @angular/common/testing : esm2015 as esm2015
Compiling @angular/common/testing : esm5 as esm5
Compiling @angular/common/testing : main as umd
Compiling @angular/router : fesm2015 as esm2015
Compiling @angular/router : fesm5 as esm5
Compiling @angular/router : esm2015 as esm2015
Compiling @angular/router : esm5 as esm5
Compiling @angular/router : main as umd
Compiling @angular/router/testing : fesm2015 as esm2015
Compiling @angular/router/testing : fesm5 as esm5
Compiling @angular/router/testing : esm2015 as esm2015
Compiling @angular/router/testing : esm5 as esm5
Compiling @angular/router/testing : main as umd
No suitable injection token for parameter 'sanitization' of class 'NgxGalleryPreviewComponent'.
npm ERR! code ELIFECYCLE
npm ERR! ivy-gallery@0.0.0 postinstall: `ivy-ngcc`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the ivy-gallery@0.0.0 postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\naruto\AppData\Roaming\npm-cache\_logs\2019-12-13T18_43_24_919Z-debug.log
kolkov commented 4 years ago

Thanks! Create demo repo for represent this bug on github.com please.

kolkov commented 4 years ago

Sorri, on desktop I see repo link.

kolkov commented 4 years ago

https://github.com/uzumakinaruto123/ngx-gallery-ivy-repro this repo is empty(

uzumakinaruto123 commented 4 years ago

Are you sure? The code was pushed as soon as I created the repo. I do see my project in the repository. It is not even private :( I checked in incognito too, I can see the project.

kolkov commented 4 years ago

Screenshot_20191214-070249_Chrome Yes, I sure.

uzumakinaruto123 commented 4 years ago

my bad :p forgot to push committed code. Repo updated.

kolkov commented 4 years ago

Hi! I don't see any code with ngx-gallery. :( Only update to Angular 8 in this commite.

uzumakinaruto123 commented 4 years ago

Yeah, I did not add ngx-gallery usage because the build is breaking by simply adding and importing the gallery module. It was ivy-ngcc build issue and no issues with the usage.

kolkov commented 4 years ago

Reopen please if problem persist...

uzumakinaruto123 commented 4 years ago

uhmm.. ok! did you update anything? I still can't build btw...

kolkov commented 4 years ago

Nothing to do for this issue. Upload your full repo please.

jemys89 commented 4 years ago

Hi! Same error,

"@angular/animations": "^8.1.2", "@angular/cdk": "^8.1.1", "@angular/common": "^8.1.2", "@angular/compiler": "^8.1.2", "@angular/core": "^8.1.2", "@angular/forms": "^8.1.2", "@angular/platform-browser": "^8.1.2", "@angular/platform-browser-dynamic": "^8.1.2", "@angular/router": "^8.1.2", "@kolkov/ngx-gallery": "^1.0.9", "@ng-bootstrap/ng-bootstrap": "^5.1.0", "angular-modal-gallery": "^5.7.1", "angular-svg-icon": "^7.2.1", "angular2-toaster": "^8.0.0",

"@angular-devkit/build-angular": "~0.801.2", "@angular/cli": "^8.1.2", "@angular/compiler-cli": "^8.1.2", "@angular/language-service": "^8.1.2", "node-sass": "^4.12.0", "protractor": "~5.4.2", "ts-node": "~8.3.0", "tslint": "~5.18.0", "typescript": "3.4.5"

kolkov commented 4 years ago

@jemys89 Hi! Provide repo on github please.

anishchenko-anton commented 4 years ago

same issue @angular/cli": "^8.3.22 "@angular/core": "^8.2.14 @kolkov/ngx-gallery": "^1.0.9

kolkov commented 4 years ago

@anishchcenko thanks! I can't reproduce this. Provide an repo please.