Simbaclaws commented 4 years ago

I created an update on how the animation for sliding works for images, this would make the image sliding hardware accelerated by using translateX instead of position left.

Please accept my pull request.

codecov[bot] commented 4 years ago

Codecov Report

Merging #23 into master will decrease coverage by 0.86%. The diff coverage is 10.00%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   38.89%   38.03%   -0.87%     
==========================================
  Files          16       16              
  Lines         707      723      +16     
  Branches      147      152       +5     
==========================================
  Hits          275      275              
- Misses        395      411      +16     
  Partials       37       37

Impacted Files	Coverage Δ
...b/ngx-gallery-image/ngx-gallery-image.component.ts	`31.00% <0.00%> (-0.32%)`	:arrow_down:
...jects/gallery/src/lib/ngx-gallery-ordered-image.ts	`0.00% <0.00%> (ø)`
...x-gallery-preview/ngx-gallery-preview.component.ts	`27.02% <0.00%> (-0.38%)`	:arrow_down:
...ery-thumbnails/ngx-gallery-thumbnails.component.ts	`24.60% <0.00%> (-0.20%)`	:arrow_down:
projects/gallery/src/lib/ngx-gallery.service.ts	`23.07% <0.00%> (-10.26%)`	:arrow_down:
projects/gallery/src/lib/ngx-gallery.component.ts	`34.95% <40.00%> (-0.58%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc749b5...df8543e. Read the comment docs.

Simbaclaws commented 4 years ago

There is an issue with the build process from Tracis CI.

I'm guessing it's related to this: https://github.com/ng-packagr/ng-packagr/issues/1592

I haven't found a solution yet. It hasn't got anything to do with my code I suppose.

Please check: See "/tmp/ng-MWMzax/angular-errors.log" for further details. On the Travis CI build.

When compiling from my macbook using npm run build:lib it succesfully compiles.

Could it be that the Travis CI build server uses a version of Android in order to compile with ng-packagr? And that since the latest version of ng-packagr it is not supported for the latest Travis CI Android Server?

I'm confused why you get this message.

kolkov commented 4 years ago

Thanks! I will try to review this PR soon as possible.

Simbaclaws commented 4 years ago

Hey, I added support for video inside the master branch of my forked repo. Please review the pull request as it should now be possible to add video files inside the image attributes.

I'm not quite sure why the builds are failing, could you please take a look at what I'm doing wrong?

EDIT: the unknown 76 android version error still exists inside the Travis CI build, I also haven't checked linting, I'll try fix the linting errors with a new commit.

Simbaclaws commented 4 years ago

Alright the build succeeded. I think it might've been linting issues that were causing the build not to complete.

I'm not sure about the codecov/patch and codecov/project though. Does code coverage make a difference?

Simbaclaws commented 4 years ago

After this pull request have been merged I'll try fixing https://github.com/kolkov/ngx-gallery/issues/4 which I have posted the theoretical solution to.

kolkov commented 4 years ago

Is it possible to fix tests coverage?

kolkov commented 4 years ago

Thanks! I check this soon as possible.

Simbaclaws commented 4 years ago

I'm not that familiar with test coverage, how would I fix those? What would I need to do?

I'm quite new to writing tests in angular. Actually I've never even done it before.

Simbaclaws commented 4 years ago

So in other words code coverage basically means code that hasn't yet had tests been written for right?

I'm new to this and would need to learn how to do this before actually writing code tests in angular. Would love to find an in-depth tutorial on the subject matter somewhere.

kolkov commented 4 years ago

Thanks for the contributions.

kolkov commented 4 years ago

Update the documentation please.

Simbaclaws commented 4 years ago

Do you mean the README.md? Or do you mean actual code documentation with code comments?

I can update README.md if that's what you're asking. That would need to become a new pull request though...

Simbaclaws commented 4 years ago

Or I could upload the README.md as README.txt in this conversation and all you'd have to do is change it back to md and upload it to your repository.

Would this documentation update suffice? README.txt

kolkov / ngx-gallery

Changed left positioning for images to translateX (update): added video support #23

Codecov Report