kolkov / ngx-gallery

A simple responsive native gallery component for Angular 8+.
https://ngx-gallery.kolkov.ru/
MIT License
115 stars 56 forks source link

Update ngx-gallery.module.ts #90

Closed andrejm7 closed 2 years ago

andrejm7 commented 2 years ago

Update for angular 13. Remove import brower

kolkov commented 2 years ago

Hi! What will it give us?

andrejm7 commented 2 years ago

I removed the browseranimation import... where there is an error in angular 13... this import must be unique in app.module

there are more users requesting this.

andrejm7 commented 2 years ago

Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.

kolkov commented 2 years ago

Thanks for the PR! I think we need to add @angular/animations to peerDependencies of packaje.json in library folder in this PR. https://stackoverflow.com/questions/59938107/how-to-add-and-install-peer-dependencies-in-angular-library https://indepth.dev/posts/1187/npm-peer-dependencies

andrejm7 commented 2 years ago

thanks