Closed un-def closed 5 years ago
Hi! I moved lib files to separate project. Update PR please.
Merging #2 into master will not change coverage. The diff coverage is
75%
.
@@ Coverage Diff @@
## master #2 +/- ##
=======================================
Coverage 47.14% 47.14%
=======================================
Files 3 3
Lines 70 70
Branches 9 9
=======================================
Hits 33 33
Misses 34 34
Partials 3 3
Impacted Files | Coverage Δ | |
---|---|---|
.../kolkov/ngx-metrika/src/lib/ngx-metrika.service.ts | 43.93% <75%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 34aa57e...cc8b0d1. Read the comment docs.
Done.
Thanks!
I was change folder structure after merge, check please.
Unfortunately, I no longer have access to the project where this library has been used, therefore I cannot recheck the library code again. But since you just moved/renamed a directory, it doesn't seem to be a problem.
Hi! Thanks for your response! No problem.)
It seems like
NgxMetrikaService.configure()
could be used for deferred configuring but it does not actually work that way:The example above doesn't work properly due to following reasons:
configure()
does not set default parameters (triggerEvent: true
,trackPageViews: true
) as the constructor does. You should set them explicitly in the config object.configure()
does not setthis.config
butonHit()
andonReachGoal()
need it.I've done slight refactoring in this PR, so it is now possible to configure
NgxMetrikaService
as in the example above.