search

kollerma / robustlmm

This is an R-package for fitting linear mixed effects models in a robust manner. The method is based on the robustification of the scoring equations and an application of the Design Adaptive Scale approach.
28 stars 9 forks source link

Define STRICT_R_HEADERS, use M_PI and R_{Calloc,Free} #15

Closed eddelbuettel closed 3 years ago

eddelbuettel commented 3 years ago

Dear Manuel, dear robustlmm team,

Your CRAN package robustlmm uses Rcpp, and is affected if we add a definition of STRICT_R_HEADERS as we would like to do. Please see the discussion at https://github.com/RcppCore/Rcpp/issues/1158 and the links therein for more context on this.

Here, instead of prefixing each #include with STRICT_R_HEADERS we set it in Makevars{,.win}. The actual change that is needed is the change from PI to MPI in one source file, and a switch to the prefix R for R_Calloc and R_Free in another. No other changes were made.

It would be lovely if you could apply this. There is no strong urgency: we aim to get this done over all affected packages in the space of a few months. If you apply it, would you mind dropping me a note by email or swinging by https://github.com/RcppCore/Rcpp/issues/1158 to confirm?

Many thanks for your help, and I hope you continue to find Rcpp helpful. Please don't hesitate to ask if you have any questions.

kollerma commented 3 years ago

Dear @eddelbuettel

Thanks for the pull request. I'm going to push a new version of robustlmm to CRAN soon.

Best, Manuel