search

kolmodin / binary

Efficient, pure binary serialisation using ByteStrings in Haskell.
Other
105 stars 67 forks source link

Document safety expectations, or the lack thereof #205

Open treeowl opened 1 year ago

treeowl commented 1 year ago

I noticed that the instances for Map, Set, IntMap, and IntSet are "unsafe" in the sense that they will happily build structures that don't obey the expected invariants if they are presented with improperly ordered input. Is this acceptable behavior (i.e., is get only supposed to be used with trusted input)? Or should the invocations of fromDistinctAscList be replaced with fromList?