search

kolo / xmlrpc

Implementation of XMLRPC protocol in Go language.
MIT License
158 stars 92 forks source link

bugfix: fix goroutine leak #46

Closed cofyc closed 6 years ago

cofyc commented 7 years ago

If clientCodec is closed, next ReadResponseHeader call on it should returns error directly, otherwise it will block on waiting codec.Ready event.

christianparpart commented 7 years ago

That is great @cofyc; We're running into the same issue and our long-running application using kolo/xmlrpc is generating over 50,000 go routines over the time, that forces us to restart the app frequently just to avoid that bug. :+1: for merging. :-)

johnzhd commented 7 years ago

I am trying github.com/nilshell/xmlrpc. Fix by the same way. Thank you. Very helpful.

kolo commented 6 years ago

This PR has been extended with a test and merged. See #52.