search

kolodny / immutability-helper

mutate a copy of data without changing the original source
MIT License
5.17k stars 186 forks source link

Typescript error with SPFX #133

Closed HadrienAllemon closed 5 years ago

HadrienAllemon commented 5 years ago

Hello everyone ! I recently tried to use Immutability helper in a sharepoint project, but no matter what I do I keep getting the same error :

Error - typescript - node_modules\immutability-helper\index.d.ts(15,75): error TS1005: ')' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,96): error TS1005: ')' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,99): error TS1109: Expression expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,121): error TS1005: ';' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,123): error TS1109: Expression expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,125): error TS1128: Declaration or statement expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,143): error TS1005: '(' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,147): error TS1005: ',' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,166): error TS1005: ')' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,175): error TS1005: ',' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,178): error TS1109: Expression expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,198): error TS1005: ',' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,207): error TS1005: ',' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,209): error TS1109: Expression expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,227): error TS1005: '(' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,231): error TS1005: ',' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,250): error TS1005: ')' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,253): error TS1109: Expression expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,273): error TS1005: ',' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,275): error TS1109: Expression expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,290): error TS1005: '(' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,294): error TS1005: ',' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(15,328): error TS1005: '(' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(16,11): error TS1005: ',' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(18,23): error TS1005: ',' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(19,23): error TS1005: ')' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(19,52): error TS1005: ',' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(19,55): error TS1109: Expression expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(19,67): error TS1005: ':' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(25,34): error TS1005: ',' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(25,35): error TS1131: Property or signature expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(25,37): error TS1131: Property or signature expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(25,56): error TS1110: Type expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(25,63): error TS1005: ';' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(25,64): error TS1109: Expression expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(26,0): error TS1128: Declaration or statement expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(26,2): error TS1109: Expression expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(27,10): error TS1005: ']' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(27,18): error TS1005: ',' expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(27,19): error TS1136: Property assignment expected. [17:26:48] Error - typescript - node_modules\immutability-helper\index.d.ts(27,31): error TS1005: '(' expected. [17:26:49] Error - 'typescript' sub task errored after 10 s

It looks like a verisonning problem, but even after updating everything I keep getting the same error. Does the module just not work in an SPFX environement ?

Thanks a lot for anyone who will take the time to read this.

jednano commented 5 years ago

Are you trying to compile the d.ts file? You might need to exclude node_modules in your tsconfig.json or something or upgrade your version of TypeScript. What version are you on?

HadrienAllemon commented 5 years ago

@jedmao

node_modules are excluded in tsconfig.json, and i'm using typescript 6.4.1 .

jednano commented 5 years ago

TypeScript is currently at 3.2.2, so you've successfully confused me.

HadrienAllemon commented 5 years ago

@jedmao Yeah sorry, for some reason I told you my npm version rather than my typescript version. I feel rather dumb right now.

npm view typescript version gets me typescript 3.2.2, the same goes for my package.json, however the tslint gets me [09:01:49] Starting subtask 'typescript'... [09:01:49] [typescript] TypeScript version: 2.4.2 upon gulp serve . I guess the tslint's typescript version can be different from the one used in the app , but I thought it might be usefull to precise it.

immutability helper uses typescript 3.2.2 doesn't it ? So I shouldn't have a problem at the level should I ?

jednano commented 5 years ago

This project uses ^3.2.2. I suggest updating anything that's using a lesser version before pointing the finger at this project, so that would include your gulp serve task.

HadrienAllemon commented 5 years ago

Well Upgrading versions ended up breaking up other things, but I found a workaround by using react-addons-update instead of immutability helper. Thanks a lot for the help !