Closed mosheduminer closed 9 months ago
Okay, so the only remaining issue is number 3 above. I have a feeling this is a playwright bug rather than anything to do with safetest code though.
The issue with 3 was it was not matching the entire text, I changed it to a regex and it passed. I also fixed up the error reporting for when that fails. Thanks for this PR!
Thanks!
Follow up from https://github.com/kolodny/safetest/issues/1
Outstanding issues:
node_modules
, distinct from the copy used in the example app. Does that seem plausible? In any case, the application code isn't affected, I think only the solid code contained in safetest is affected (see the next point).createRoot
orrender
will never be disposed". This is probably the same issue as above, due to thecreateMemo
andcreateRenderEffect
used insafetest/solid
using a different copy of solid, but it's possible that it's actually a symptom I misconfigured something.await expect(text).toHaveCSS("text-decoration", "line-through");
) throws without any text in its error, despite the app code appearing to be behaving correctly.Regarding createOverride, I wasn't exactly sure of the full extent of the features meant to be provided by react-overrides, so I did not include that API (at least for now).