search

kolodny / wavy

use ~ in require and import calls
378 stars 20 forks source link

postinstall hook flips out due to wavy symlink #6

Open cdaringe opened 8 years ago

cdaringe commented 8 years ago

problem statement

npm init && npm i --save wavy && [add some npmpostinstallscript] && npm i

watch her buck.

🛰  cdieringer:~/node/wavy-test$ npm i
npm WARN package.json wavy-test@1.0.0 No description
npm WARN package.json wavy-test@1.0.0 No repository field.
npm WARN package.json wavy-test@1.0.0 No README data

> wavy-test@1.0.0 postinstall /Users/cdieringer/node/wavy-test/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~
> echo 'bananas'
...
> coinstac-ui@1.0.0 postinstall /Users/cdieringer/node/coinstac-ui/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~
> echo 'bananas'

bananas

> coinstac-ui@1.0.0 postinstall /Users/cdieringer/node/coinstac-ui/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~
> echo 'bananas'

bananas

clearly, my postinstall hook does echo 'bananas'

kolodny commented 8 years ago

I can't seem to replicate this, can you provide the instruction to make this happen. Here's what I'm trying now

$ mkdir tmp
$ npm init -y >/dev/null && npm i --save wavy && echo 'bananas' && npm i
$ find .
.
./node_modules
./node_modules/wavy
./node_modules/wavy/.npmignore
./node_modules/wavy/.travis.yml
./node_modules/wavy/package.json
./node_modules/wavy/postinstall.js
./node_modules/wavy/README.md
./node_modules/~
./package.json
$
cdaringe commented 8 years ago

np.

here: https://github.com/cdaringe/wavy-test

clone it. npm install twice. im on npm 2.15 FTR

kolodny commented 8 years ago

I see, I'm not sure how to go about fixing that. Any ideas?

cdaringe commented 8 years ago

maybe remove and re-add the link on every postinstall? or, point the link to the dir it resides on pre-install, then on post install move it's target back up a dir?