search

kolofordjango / kolo

See everything happening in your running Django app. All without leaving VSCode
https://kolo.app
486 stars 14 forks source link

Why do some of the views open in a split view? #68

Closed kevinrenskers closed 9 months ago

kevinrenskers commented 10 months ago

When you click on a frame or a SQL query, the information opens in a new tab in your active editor. But when you click on request or response, it opens in a split view on the right side. I find this a bit annoying, and would like to be able to configure this behavior.

wilhelmklopp commented 9 months ago

@kevinrenskers I'm looking in this a bit today. Did you have any thoughts on what kind of configuration option you'd like to see here?

I'm currently thinking of providing just one on/off setting which is essentially "never open things in a split view". Is that more or less what you were looking for?

kevinrenskers commented 9 months ago

Yeah, basically. I just never want stuff to open in a split view, and think the default option should be to not do that.

wilhelmklopp commented 9 months ago

@kevinrenskers thanks!

I can definitely see not wanting a split view when clicking on various things in the kolo sidebar (like a frame, or request, or sql query information).

But what about when clicking on a node in the visualisation or on a code annotation within code? Would you want those to open in a split view or also prefer no split view? Showing both in the video:

https://github.com/kolofordjango/kolo/assets/7718702/9e1c362d-187b-4553-8f31-e62740c80c08

kevinrenskers commented 9 months ago

I guess that would make sense, although personally I just get lost with what tab is in what split view and I end up being annoyed haha.

But the split view usage should definitely be limited to those kinds of cases where it really makes sense. Thanks!

wilhelmklopp commented 9 months ago

Many thanks for your feedback here @kevinrenskers

I just released version 2.14.0 of the VSCode extension, which comes with an improved split view experience.:

  • All views available via the Kolo sidebar now open in your currently active editor, rather than defaulting to opening a new editor to the side. Some views (currently just the Visualization and the SQL Query Overview) can also be opened in a split view experience via a new menu item.
    • In a few places Kolo provides links/codelenses that let you jump to a location in the code (such as the Visualization, frame span info vdocs, or the sources of SQL queries in the SQL Query Overview). Those links will now always open to the left or the right of your currently active editor, so that you can view the code and also retain the context of the Kolo view you came from. This is mostly the same behaviour as before, but significantly more reliable.