kolton / d2bot-with-kolbot

d2bot game manager by D3STROY3R with kolbot libs by kolton for d2bs
346 stars 332 forks source link

Pickit saves wrong items #3094

Open 2famous opened 3 years ago

2famous commented 3 years ago

Lines in the .nip file looks good. But it saves crap rings/amus (also crafted)

Samael36 commented 3 years ago

Can you copy/paste us the line of the rings/amus it keeps? You can see to the right of the console where it logs kept items, it will show a photo of the item with the line. You can go to that line after and delete it or modify it.

2famous commented 3 years ago

Here is what is shown in kolbot: [https://i.imgur.com/C13xpSW.png]

And in the pickit it says: [Type] == Amulet && [Quality] == Crafted # [ItemAddClassSkills] == 2 && [FCR] >= 10 && ([Dexterity] >= 10 || [Strength] >= 10) + alot of res :P

2famous commented 3 years ago

But it's not just that one line, I recently noticed some lines had "))" or "((" in them so i removed all of them. After that more than 10 lines of rings and amus are doing this.

Samael36 commented 3 years ago

Is that really on line #2523? Because the Amulet you showed doesn't match the line.

Samael36 commented 3 years ago

Don't remove the brackets. They are important. Compare these two lines as an example:

[ItemAddClassSkills] == 2 && [FCR] >= 10 && ([Dexterity] >= 10 || [Strength] >= 10)

[ItemAddClassSkills] == 2 && [FCR] >= 10 && [Dexterity] >= 10 || [Strength] >= 10

The first one will keep +2 class, 10+ fcr and either 10+ dexterity or 10+ strength. The second will keep +2 class, 10+ fcr, 10+ dexterity OR any amulet with 10+ strength.

2famous commented 3 years ago

I have atleast 1 "( and )" on each side of course. And yes, I know that it doesnt match. Trust me I've double checked on each wrong line. That's why I'm here, Im 100% sure it's correct in the .nip file

Here is another example: https://i.imgur.com/S7FAcZe.png In nipfile: [Type] == Ring && [Quality] == Crafted # [MaxHP] >= 30 && [FCR] >= 10 && ([Dexterity] >= 13 || [Strength] >= 17) && ([ColdResist]+[FireResist] >= 15) || ([ColdResist]+[LightResist] >= 15) || ([FireResist]+[LightResist] >= 15)

Samael36 commented 3 years ago

The second photo you sent matches the line. I think the line you are trying to use is this: [Type] == Ring && [Quality] == Crafted # [MaxHP] >= 30 && [FCR] >= 10 && ([Dexterity] >= 13 || [Strength] >= 17) && ([ColdResist]+[FireResist] >= 15 || [ColdResist]+[LightResist] >= 15 || [FireResist]+[LightResist] >= 15)

Otherwise, it will keep any crafted ring with 30 && [FCR] >= 10 && ([Dexterity] >= 13 || [Strength] >= 17) && ([ColdResist]+[FireResist] >= 15) OR ([ColdResist]+[LightResist] >= 15) OR ([FireResist]+[LightResist] >= 15)

2famous commented 3 years ago

It doesnt match, where is the Fcr/Str/dex/maxhp? The only thing that's matching is the fire resist ([ColdResist]+[FireResist] >= 15) // ([ColdResist]+[FireResist] >= 15)

Samael36 commented 3 years ago

Your line means Amulet with: [MaxHP] >= 30 && [FCR] >= 10 && ([Dexterity] >= 13 || [Strength] >= 17) && ([ColdResist]+[FireResist] >= 15) OR Amulet with: ([ColdResist]+[LightResist] >= 15) OR Amulet with: ([FireResist]+[LightResist] >= 15)

Because you have this ) after: ([ColdResist]+[FireResist] >= 15 and this ( before: [FireResist]+[LightResist] >= 15) Take the extra parenthesis away and you now have this: ([ColdResist]+[FireResist] >= 15 || [ColdResist]+[LightResist] >= 15 || [FireResist]+[LightResist] >= 15)

Which means Amulet with: : [MaxHP] >= 30 && [FCR] >= 10 && ([Dexterity] >= 13 || [Strength] >= 17) AND one of the following: (cold+fire OR cold+light OR fire+light)

It gets complicated to explain the difference, but I hope you get it.

2famous commented 3 years ago

I totally understand, the resistance is the only thing that's matching. The FCR or MaxHP is not in the saved amulets. Anyways I removed the (resistance) on the lines the console showed. Coming back for more answers.

2famous commented 3 years ago

Still doesnt work. Found something else: https://i.imgur.com/4W0hu4K.png

Pickit: [Type] == Amulet && [Quality] >= rare # [itemaddtrapsskilltab] >= 2 && [fcr] >= 10 && [dexterity] >= 18