kolton / d2bot-with-kolbot

d2bot game manager by D3STROY3R with kolbot libs by kolton for d2bs
346 stars 333 forks source link

Battle Orders Script and Excessive Chickening #684

Open Kellen-Stuart opened 6 years ago

Kellen-Stuart commented 6 years ago

The bot won't heal itself before going to Catacombs Level 2 and this will cause consecutive chickens.

The way it's been happening to me is

  1. Bot chickens in some Baal run
  2. Next game bot doesn't heal before going to Cata 2
  3. Bot Chickens again.. and again.. and again... until i fix it

Thank god I set a min game time or I woulda been temp banned for days.

I was able to fix this by adding the line

Town.initNPC("Heal","heal");

But this shouldn't be necessary due to the fact that the script already calls

Town.doChores();

The bug lies within Town.doChores() when it does a calculation to check if the bots needs to be healed or not.

My sorc is set to chicken at 50% health (for HC), and you'd assume the calculation should tell the bot to go heal at that health level.

I'll look into it, but maybe someone has a fix?

My method is just a hack, but the calculation in the method Town.needHealing needs to be fixed.

Hope I narrowed it down enough; I might even add a fix myself, but I'm not sure how to become a true contributer on this project

DarkHorseDre commented 6 years ago

what is Config.HealHP set to?

jaenster commented 6 years ago

Well if your chicken and heal in town procetage is the same (default 50% i believe), you should be happy the chicken comes first.

So, please answer @DarkHorseDre question =)