search

koltyakov / gosip-sandbox

🐣 Sandbox: Samples, experiments for Gosip client
https://github.com/koltyakov/gosip
MIT License
6 stars 3 forks source link

Allow enabling of extensions for ondemand auth #8

Open lllama opened 2 months ago

lllama commented 2 months ago

It would be very useful to have extensions enabled for on-demand auth. Would it be possible for this to be a config option? Either allow all extensions or use the --disable-extensions-except flag for Chrome.

koltyakov commented 1 month ago

Hi @lllama, sorry, missed this one.

Just wondering why would you need extensions for the auth form?

lllama commented 1 month ago

Hi @koltyakov! In our environment we use a Microsoft Chrome extension that Does Something (TM) with InTune as part of the SSO dance to ensure the device is compliant, so it would be useful if this could be enabled.

koltyakov commented 1 month ago

@lllama can I ask you a favor of testing this?

Sorry for having little time testing on my end today.

I extended the config with optional "chromeArgs", which can contain chromium command line switches. This should give a room to pass any custom flag.

// config/private.json
{
  "siteUrl": "https://contoso.sharepoint.com/sites/my-site",
  "chromeArgs": {
    "--disable-extensions-except": "my-corp-plugin"
  }
}

The change is pushed to chrome-args branch, and can be installed as dependency using @chrome-args target.

Could you please also test with and without chromeArgs?

Thank you in advance!