search

koltyakov / sp-rest-proxy

🌐 SharePoint API Proxy for local development
MIT License
172 stars 43 forks source link

Check error responses #38

Closed koltyakov closed 6 years ago

koltyakov commented 6 years ago

https://github.com/SharePoint/PnP-JS-Core/issues/652

koltyakov commented 6 years ago

I have applied some changes in Err responses. On the test use cases after changes sp-rest-proxy showed identical responses as while requesting REST API being on SP pages. Yet some testing might be required. @brunoferreira2007, could you please check if v 2.5.2 fixes your issue with PnP JS Core and 404 err catches?

brunoferreira2007 commented 6 years ago

Hi @koltyakov ,

Yes, the issue is fixed now. thanks image

koltyakov commented 6 years ago

Cool! Once again, thank you for finding this out. Closing the issue.