search

komadori / bevy_mod_outline

Apache License 2.0
123 stars 10 forks source link

HDR and active OutlineVolume affects DirectionalLight #37

Closed jannik4 closed 4 months ago

jannik4 commented 6 months ago

If a camera with hdr activated and a DirectionalLight is used in the scene, the rendering of an outline affects the light of the entire scene. This only happens with hdr and a DirectionalLight. Non-hdr cameras and PointLights seem not to be affected.

Notice the subtle color change of the plane.

Without Outlines in the scene: Screenshot 2024-04-26 223037

With Outlines in the scene: Screenshot 2024-04-26 223024

jannik4 commented 6 months ago

Example to reproduce: https://github.com/jannik4/bevy_mod_outline/blob/4934a02ac69935e22f994c90886e20b9cad872b3/examples/shapes.rs

komadori commented 4 months ago

I think this has the same cause as #36. Writing to the sampled colour attachment overwrites the unsampled one, and effectively disable some of the earlier post-processing steps such as tone-mapping.

komadori commented 4 months ago

Fixed in 0.7.1.