search

komamitsu / spring-data-sqlite

Apache License 2.0
14 stars 3 forks source link

Merging into Spring Boot DATA JDBC #39

Open rudolfschmidt opened 3 months ago

rudolfschmidt commented 3 months ago

Hey, have not tested your implementation but I tried data jdbc out and noticed that there is a lack of support for sqlite.

Your implementation looks not bad so I wonder why not merging into spring boot data jdbc directly?

komamitsu commented 3 months ago

@rudolfschmidt Thanks for the suggestion!

Let me share my thoughts. Most of the implementation of this project is a basically integration to inject SQLite specific behavior to Spring Data JDBC. So, I guess those implementation would be removed once the Spring Data JDBC team decides to officially support SQLite. So, I'm not feeling so motivated to ask them to merge this project.

Thanks again for considering it, though.

rudolfschmidt commented 3 months ago

I agree but why not contributing with a PR then?

Please take a look and share your thoughts: https://github.com/spring-projects/spring-data-relational/pull/1770