search

komentify / meteor-comments-ui

Simple templates for comment functionality in your Meteor App
MIT License
76 stars 40 forks source link

Adding Media Code to Single Comments Template #72

Closed mayvn10 closed 8 years ago

mayvn10 commented 8 years ago

@matteodem tried to do a pull request but was denied so I am logging an issue for it.

Your commentsSingleComments.html located in

lib/components/commentsSingleComment/commentsSingleComment.html

is missing the media code below in the bootstrap and ionic templates:

{{#if media.content}}
<div class="content-media">
 {{{mediaContent}}}
</div>
{{/if}}
matteodem commented 8 years ago

What do you mean by denied?

mayvn10 commented 8 years ago

I cloned your repo, created a branch for this fix, committed it, and then when I tried to push it, it said I was denied for the push. I'll look into it later but this should be a quick fix since it's just adding the media code to the 2 templates.

matteodem commented 8 years ago

you need to create a fork and then push it in your fork, after that you can create a pull request over the UI.

mayvn10 commented 8 years ago

Ah, I figured I missed a step. Thanks I'll do this later today.

matteodem commented 8 years ago

This is fixed in the latest version 1.1.0, see https://github.com/ARKHAM-Enterprises/meteor-comments-ui/blob/master/GUIDE.md