search

kometbomb / klystrack

A chiptune tracker
http://kometbomb.github.io/klystrack/
Other
482 stars 29 forks source link

Crash when song begins a new loop #211

Closed DeltaRazero closed 7 years ago

DeltaRazero commented 7 years ago

I haven't tested this a lot, but when playing back this file (put it in a zip file) BotB 25394 shinichi - reasoneater.zip , when klystrack goes back to the start and replays/loops it crashes the program.

It also results in resetting all preferences somehow when reopening klystrack.

kometbomb commented 7 years ago

Can definitely reproduce the crash with this file. Thanks!

kometbomb commented 7 years ago

The cause of the trouble was the wavetable reading outside the sample area. Might fix some other random crashes as well. Fixed in kometbomb/klystron@7deb44159fddd8b193f02ec83f8a3e6ed4614003

kometbomb commented 7 years ago

It would be super nice if you could test if the song crashes. Here's a fix: klystrack-1.7.1-win32.zip

I ran it through Valgrind and did not get the error and on my Windows machine it doesn't crash anymore but you never know with these things.

DeltaRazero commented 7 years ago

Yep, seems to be fixed. Sorry for the late reply, unfortunately didn't get properly notified by GitHub.

kometbomb commented 7 years ago

NP, better late than never! Thanks for confirming. :)