Making a new song doesn't reset pattern lengths

kometbomb / klystrack

A chiptune tracker

http://kometbomb.github.io/klystrack/

Other

485 stars 28 forks source link

Making a new song doesn't reset pattern lengths #213

Closed FreeFull closed 6 years ago

FreeFull commented 7 years ago

To reproduce:

Open an existing song, for example "Ocean Loader III.kt" from the example songs.
Clear everything with "Ctrl-n" or "New song" from the File menu
Any patterns you add in the pattern editor will have the same length that they had in the previous song

This means that to get a clean state, you currently have to close klystrack and open a new instance of it. "Zap sequence" doesn't do anything to the pattern lengths either.

kometbomb commented 7 years ago

Do you have the "Same as STEP" option checked in prefs?

FreeFull commented 7 years ago

I do have that option checked.

FreeFull commented 7 years ago

It seems the commit with the fix got reverted. Should the issue be reopened?

Edit: Sorry, I somehow missed the commit right after the revert, with the fix.

kometbomb commented 7 years ago

I reverted it but also recommitted later. See 2a2cbaf913e98.

But maybe you are still getting the wrong behavior... could you please check with the latest build (1.7.3)?

FreeFull commented 6 years ago

The problem has been fixed by 2a2cbaf.