search

kometbomb / klystrack

A chiptune tracker
http://kometbomb.github.io/klystrack/
Other
481 stars 29 forks source link

Make 3 #264

Closed rofl0r closed 5 years ago

rofl0r commented 5 years ago

a couple improvements, including addition of an install target (test via make DESTDIR=foobar install).

i'd also like to install examples, but the split of songs/n00bstar-songs and instru... is a bit annoying because they all need extra rules. could i just move the n00bstar stuff into the respective directory? e.g.

 rename examples/songs/{n00bstar-examples/Arps.kt => n00bstar-Arps.kt} (100%)

or even leave the n00bstar prefix away entirely ? i suspect klystrack allows to add comments, so the author could be credited that way. however's that's stuff for the next PR. let me know what you think.

kometbomb commented 5 years ago

I would like to preserve the directory structure. Is it not possible to handle the install recursively? Extra shell script or something?

rofl0r notifications@github.com kirjoitti ke 20. helmikuuta 2019 klo 20.31:

a couple improvements, including addition of an install target (test via make DESTDIR=foobar install).

i'd also like to install examples, but the split of songs/n00bstar-songs and instru... is a bit annoying because they all need extra rules. could i just move the n00bstar stuff into the respective directory? e.g.

rename examples/songs/{n00bstar-examples/Arps.kt => n00bstar-Arps.kt} (100%)

or even leave the n00bstar prefix away entirely ? i suspect klystrack allows to add comments, so the author could be credited that way. however's that's stuff for the next PR. let me know what you think.

You can view, comment on, or merge this pull request online at:

https://github.com/kometbomb/klystrack/pull/264 Commit Summary

  • update klystron
  • Makefile: use klystron's SDL defs
  • Makefile: document deps to version.h
  • Makefile: add install target

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kometbomb/klystrack/pull/264, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCK6fHWe0YaMWfkVmsB6AH_EYMQOGByks5vPZRkgaJpZM4bF2Gb .