komikku-app / komikku

Free and open source manga reader for Android
Apache License 2.0
294 stars 10 forks source link

Auto Delete chapters #297

Open HikaruIchijyo opened 2 weeks ago

HikaruIchijyo commented 2 weeks ago

Describe your suggested feature

Auto delete chapters if a manga is removed from your library currently it shows popup and sometimes peeps forget to click on it

Other details

No response

Acknowledgements

kana-shii commented 2 weeks ago

If that happens, you can go to Settings > Advanced > Clean Invalid Downloads. Easy fix edit: rn this option actually doesn't work yet. For now, try to remember to click the option or delete the folders yourself until there's a fix

cuong-tran commented 2 weeks ago

If that happens, you can go to Settings > Advanced > Clean Invalid Downloads. Easy fix

Is there that feature? I think I haven’t implemented it yet, only have a menu.

cuong-tran commented 2 weeks ago

It should be a pop-up as it is right now. I don't think a permanent toggle in setting is practical. Maybe an option in setting to allow delete invalid download is more reasonable

kana-shii commented 2 weeks ago

If that happens, you can go to Settings > Advanced > Clean Invalid Downloads. Easy fix

Is there that feature? I think I haven’t implemented it yet, only have a menu.

I thought that it was a feature from Mihon, it seems that I was wrong It is there (in preview and stable versions) but I'm not sure if it actually works rn tbh I always clicked on it and just thought it did kekw

kana-shii commented 2 weeks ago

It should be a pop-up as it is right now. I don't think a permanent toggle in setting is practical. Maybe an option in setting to allow delete invalid download is more reasonable

Its an option where a pop-up appears saying "Invalid downloads cleaned" and it instantly starts checking the downloads again but it looks like it doesn't work. Just tested it out

cuong-tran commented 2 weeks ago

Yeah, some work in progress before which I haven't finished

HikaruIchijyo commented 2 weeks ago

If that happens, you can go to Settings > Advanced > Clean Invalid Downloads. Easy fix

Is there that feature? I think I haven’t implemented it yet, only have a menu.

I thought that it was a feature from Mihon, it seems that I was wrong It is there (in preview and stable versions) but I'm not sure if it actually works rn tbh I always clicked on it and just thought it did kekw

same here i always click on that

HikaruIchijyo commented 2 weeks ago

It should be a pop-up as it is right now. I don't think a permanent toggle in setting is practical. Maybe an option in setting to allow delete invalid download is more reasonable

sure