Unable to Adjust the Order of Merged Comics

RejectVanity commented 2 months ago

Steps to reproduce

Merge any comic books,
Adjust the order of merged comics in 'Merge settings'.

Expected behavior

The order of merged comics can be adjusted normally.

Actual behavior

Unable to adjust.

Crash logs

No response

Komikku version

1.11.3-9318

Android version

Android 14

Device

POCOF4 (munch)

Other details

When adjusting the order of comics, the chapters are rearranged as well. For example, the first and second chapters of comic "a" and the first and second chapters of comic "b" are originally ordered as a1, a2, b1, b2. After the order is adjusted, they become b1, b2, a1, a2.

In the case where 'Allows deduplication' is disabled, I would like to allow adjusting the order of the comics as I mentioned.

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 1.11.2.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

cuong-tran commented 1 month ago

Did it ever work before?

RejectVanity commented 1 month ago

Did it ever work before?

I just reverted to the 'Komikku-arm64-v8a-r9312.apk' version, and still can't adjust the order.

cuong-tran commented 1 month ago

There has never been any ability to adjust merged entries order yet. Why do you need to adjust order?

RejectVanity commented 1 month ago

There has never been any ability to adjust merged entries order yet. Why do you need to adjust order?

The symbol in front that looks like ‘=’ generally indicates that you can press and hold it to adjust the order. I usually use the ‘merge’ function to combine serialized manga, either by parts (such as Part 1, Part 2) or by seasons (such as Season 1, Season 2).

JoeloJoestar commented 1 month ago

The order matters for the "Dedupe by priority" mode, and so it lets you set up the "priority". I just checked this and it is orderable only after selecting the "Dedupe by priority" mode and not the others. It is not very intuitive because there are no visual clues of this activating option, so this could be improved. The function though works, as in latest preview build.

RejectVanity commented 1 month ago

There has never been any ability to adjust merged entries order yet. Why do you need to adjust order?

When adjusting the order of comics, the chapters are rearranged as well. For example, the first and second chapters of comic "a" and the first and second chapters of comic "b" are originally ordered as a1, a2, b1, b2. After the order is adjusted, they become b1, b2, a1, a2.

(I have added this information in the "Other details" section.)

JoeloJoestar commented 1 month ago

@RejectVanity please read my comment above if you did not and you find out it is working.

RejectVanity commented 1 month ago

@RejectVanity please read my comment above if you did not and you find out it is working.

That is only to adjust the priority of removing duplicates, not to adjust the order of comics (in other words, chapters).

JoeloJoestar commented 1 month ago

@RejectVanity as I understand the Merge function has been designed to fuse sources together to fill the missing chapters void, and so it makes to have this option for deduplication, why would you want the same chapters of more sources stacked like you described instead of just having multiple entries?

JoeloJoestar commented 1 month ago

It's like doubling the number of chapters for a Manga.. Imagine to track this entry.. It's also against every sorting logic currently implemented.

RejectVanity commented 1 month ago

It's like doubling the number of chapters for a Manga.. Imagine to track this entry.. It's also against every sorting logic currently implemented.

My idea is to merge the entire series into one book (e.g., Season 1, Season 2...), as some works are serialized in parts. I believe this should be considered a feature request, not a "bug" report.

A friendly developer also tagged this issue as an "enhancement." I believe "seeking common ground while reserving differences" is one of the goals of open-source projects.

RejectVanity commented 1 month ago

It's like doubling the number of chapters for a Manga.. Imagine to track this entry.. It's also against every sorting logic currently implemented.

In the case where 'Allows deduplication' is disabled, I would like to allow adjusting the order of the comics as I mentioned.

JoeloJoestar commented 1 month ago

Alright @RejectVanity I get you and I agree. The Merge function can be even more useful after this, so the point for merging won't be to just fill the voids but to merge more separated chapters of a series into one, then making the library less disordered.

So like I said, the current issue is that only if we activate the deduplication we can adjust the order of the chapters somehow, so not yet possible to have a1, a2, b1, b2 if we don't wanna deduplicate.

Besides, it would be very useful too if we could just drag-and-drop single chapters of an entry.

komikku-app / komikku